From: Jasper St. Pierre <jstpierre@mecheye.net>
Date: Thu, 11 Jul 2013 18:25:08 +0000 (-0400)
Subject: search: Ensure that we correctly remove remote search providers
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~3866
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=4efd363134e591e1e298c33c64509c627234a1c2;p=gnome-shell.git

search: Ensure that we correctly remove remote search providers

When we reload the remote search providers, we currently try to remove
all remote providers, and then re-scan. It turns out that we sometimes
remove the wrong providers from the remote provider list, causing us to
have some providers not correctly unloaded.

https://bugzilla.gnome.org/show_bug.cgi?id=700283
---

diff --git a/js/ui/search.js b/js/ui/search.js
index 03348b2d8..1fd442e1f 100644
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -31,7 +31,7 @@ const SearchSystem = new Lang.Class({
 
         let remoteIndex = this._remoteProviders.indexOf(provider);
         if (remoteIndex != -1)
-            this._remoteProviders.splice(index, 1);
+            this._remoteProviders.splice(remoteIndex, 1);
     },
 
     getProviders: function() {